[pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server
Date: 2020-08-06 09:01:48
Message-ID: CAM9w-_mrO59WXONZbjBfzv2LiYkzjaR2_MikWuVdUMJ=9YyNjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix the issue mentioned in the subject.
Regarding hiding the color legend when the server is disconnected, I feel
it's good to have the legend visible as it says it's a graph. Otherwise, a
box with error is ambiguous. Plus, it's not going to change anyway even if
graph data is available or not.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM5716.patch application/octet-stream 2.5 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2020-08-06 09:51:22 Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server
Previous Message Akshay Joshi 2020-08-06 07:13:23 Re: Patch for SonarQube code scan fixes.