| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server |
| Date: | 2020-08-06 11:24:40 |
| Message-ID: | CANxoLDeuUx3XL3=uHV6vN+wnjhjqa1OJBnR19da6VZYFqbCHmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Thu, Aug 6, 2020 at 2:32 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the issue mentioned in the subject.
> Regarding hiding the color legend when the server is disconnected, I feel
> it's good to have the legend visible as it says it's a graph. Otherwise, a
> box with error is ambiguous. Plus, it's not going to change anyway even if
> graph data is available or not.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-08-06 11:29:31 | Re: Code coverage report generation for JS files |
| Previous Message | Akshay Joshi | 2020-08-06 11:23:54 | pgAdmin 4 commit: Fixed an issue where ajax call continues to fire even |