| From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server |
| Date: | 2020-08-06 09:51:22 |
| Message-ID: | CAKKotZR57y-M_qco_TqZXRxg_9=54Joz+y+RuxrhvFApQC5Pjw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hello,
On Thu, Aug 6, 2020 at 2:32 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the issue mentioned in the subject.
> Regarding hiding the color legend when the server is disconnected, I feel
> it's good to have the legend visible as it says it's a graph. Otherwise, a
> box with error is ambiguous. Plus, it's not going to change anyway even if
> graph data is available or not.
>
I disagree.
A simple question, as a user can you relate those red/green/blue colors
with what's currently shown on the screen?
[image: image.png]
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2020-08-06 10:20:52 | Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server |
| Previous Message | Aditya Toshniwal | 2020-08-06 09:01:48 | [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server |