Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> I just found an, umm, embarrassing issue with this. It asks for the cancel
> confirmation even when pressing the OK button :-o
>
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue.

>
> Can you fix that ASAP please?
>
> On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks, applied.
>>
>> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to warn the user before closing an unsaved
>>> properties dialog.
>>> Additionally, I have added a preference option in Browser->Display where
>>> the user can disable this. Default is enabled.
>>> Docs updated.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"