| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved |
| Date: | 2019-10-29 15:31:11 |
| Message-ID: | CA+OCxozd=s4vL5w8yCH2oF_ZF0mrUY3n24oCLpwSsNgfU9t7aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
I just found an, umm, embarrassing issue with this. It asks for the cancel
confirmation even when pressing the OK button :-o
Can you fix that ASAP please?
On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, applied.
>
> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to warn the user before closing an unsaved
>> properties dialog.
>> Additionally, I have added a preference option in Browser->Display where
>> the user can disable this. Default is enabled.
>> Docs updated.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-10-29 15:51:35 | pgAdmin 4 commit: Ensure Javascript errors during Query Tool execution |
| Previous Message | Dave Page | 2019-10-29 14:35:23 | Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved |