Re: [pgAdmin][RM4564] JS errors in the Query Tool are caught as ajax errors

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4564] JS errors in the Query Tool are caught as ajax errors
Date: 2019-10-29 15:51:50
Message-ID: CA+OCxoy3PxD7YNuV1E1n-=dO_+m3R+0NBRm3NDwCWw-3v3Qqmg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Oct 29, 2019 at 12:13 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to throw JS errors to browser consoles. JS errors
> after execute are now caught by axios catch which shows a false message -
> "Not connected to the server or the connection to the server has been
> closed."
> This will help is debugging in case of JS erors.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-10-30 04:39:50 Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved
Previous Message Dave Page 2019-10-29 15:51:35 pgAdmin 4 commit: Ensure Javascript errors during Query Tool execution