From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][SonarQube] Reduce cognitive complexity |
Date: | 2020-08-12 10:32:35 |
Message-ID: | CAM9w-_kw65GyBa2XxvkOYa6Kovx10BqixXGN8bD8B1CimFKZDg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
Attached is the patch to fix certain errors occurring when saving
preferences. This is the regression of patch committed.
Please review.
On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks, patch applied.
>
> On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch will reduce cognitive complexity for functions as below:
>> web/.../servers/pgagent/schedules/__init__.py - 17 to 15
>> web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
>> web/pgadmin/setup/user_info.py - 22 to 15
>> web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
sonarqube.cognitive.pref_fix.patch | application/octet-stream | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-08-12 12:13:07 | pgAdmin 4 commit: Resolve schema diff dependencies by selecting the app |
Previous Message | Akshay Joshi | 2020-08-12 09:11:32 | pgAdmin 4 commit: Fixed an issue where debugger doesn't work if the sea |