Re: [pgAdmin][SonarQube] Reduce cognitive complexity

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Date: 2020-08-11 10:02:41
Message-ID: CANxoLDdGNDLaZzRNUC19P4fFr865pH8b7Hu0dXsRv-3hmBt1ag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached patch will reduce cognitive complexity for functions as below:
> web/.../servers/pgagent/schedules/__init__.py - 17 to 15
> web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
> web/pgadmin/setup/user_info.py - 22 to 15
> web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-08-11 10:02:59 Re: [pgAdmin][Patch] - Bug #5567 - Conversion of bytea to binary string representation works in psql but results in error in pgadmin
Previous Message Akshay Joshi 2020-08-11 10:01:45 pgAdmin 4 commit: Fixed an issue where conversion of bytea to the binar