Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied.

On Wed, Aug 12, 2020 at 4:03 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix certain errors occurring when saving
> preferences. This is the regression of patch committed.
> Please review.
>
> On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch will reduce cognitive complexity for functions as below:
>>> web/.../servers/pgagent/schedules/__init__.py - 17 to 15
>>> web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
>>> web/pgadmin/setup/user_info.py - 22 to 15
>>> web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15
>>>
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com>
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*