Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button
Date: 2017-06-12 14:52:01
Message-ID: CAM5-9D85mNA9yGdqrZzZZ2+ko95w_Ryxv6KCQCbaTt0OMiX4dQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Please find updated patch.

On Mon, Jun 12, 2017 at 7:58 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> > Hi
> >
> > I confirm this is updated patch.
>
> Thanks. Something else seems to have changed that I can't spot. Only
> <return> should be ignored if a child control has focus - Escape and
> F1 should continue to work. I tried moving the:
>
> if (panel && panel['_type'] !== 'node_props') return;
>
> into the branch for keyCode.ENTER, but that doesn't seem to help.
>
​Fixed.​

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
Feature_1535_rebased_v1.patch application/octet-stream 20.8 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shruti B Iyer 2017-06-12 14:53:03 Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Previous Message Dave Page 2017-06-12 14:44:32 Re: [pgAdmin4] [PATCH] History Tab rewrite in React