Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button
Date: 2017-06-12 14:28:42
Message-ID: CA+OCxowBUuCghS8DMDG8tbwMMLQwrmgMLmfjg4Qqi5ZtWAYa+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> I confirm this is updated patch.

Thanks. Something else seems to have changed that I can't spot. Only
<return> should be ignored if a child control has focus - Escape and
F1 should continue to work. I tried moving the:

if (panel && panel['_type'] !== 'node_props') return;

into the branch for keyCode.ENTER, but that doesn't seem to help.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-12 14:33:37 Re: [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window
Previous Message Shruti B Iyer 2017-06-12 14:24:54 Re: [pgAdmin4] [PATCH] History Tab rewrite in React