Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button
Date: 2017-06-12 15:43:39
Message-ID: CA+OCxowoRDn-pPQRwLsmWSH1fA1-9FEyt-MC8cH11KCeQvi=5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find updated patch.
>
> On Mon, Jun 12, 2017 at 7:58 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > Hi
>> >
>> > I confirm this is updated patch.
>>
>> Thanks. Something else seems to have changed that I can't spot. Only
>> <return> should be ignored if a child control has focus - Escape and
>> F1 should continue to work. I tried moving the:
>>
>> if (panel && panel['_type'] !== 'node_props') return;
>>
>> into the branch for keyCode.ENTER, but that doesn't seem to help.
>
> Fixed.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shruti B Iyer 2017-06-12 15:43:50 [pgAdmin4] [PATCH] Translatable Text in Query Results Header
Previous Message Dave Page 2017-06-12 15:43:33 pgAdmin 4 commit: Teach dialogues about Escape to cancel, Enter to Save