[pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X
Date: 2017-07-28 07:12:35
Message-ID: CAM5-9D83KF2KzmDA6o95V1a=7DA609z_HT3cT-FHrv4ZcPMDOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I inspect the react code and in call stacks, found `process.env.NODE_ENV`
is undefined due to which 'SyntheticEvent.call' is not callable.

So, to fix this, i add 'definePlugin' to plugins for `dev` environment in
`webpack.config.js`. Initially it was added only for `production`
environment. but it is needed for both, because React code is conditional
based on environment variables set.

Please find attached patch and review.

Thanks,
Surinder

Attachment Content-Type Size
RM_2596.patch application/octet-stream 310 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-07-28 08:21:31 Re: Discussion on improving alertify notifications logic
Previous Message Akshay Joshi 2017-07-28 05:32:24 Re: Discussion on improving alertify notifications logic