| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X |
| Date: | 2017-07-28 10:31:32 |
| Message-ID: | CA+OCxowvKgLbnaLpVh13=A_ngpveUwYK8zcVsnswfrKt5D4+6w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Ashesh, can you deal with this please? Thanks.
On Fri, Jul 28, 2017 at 8:12 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> I inspect the react code and in call stacks, found `process.env.NODE_ENV`
> is undefined due to which 'SyntheticEvent.call' is not callable.
>
> So, to fix this, i add 'definePlugin' to plugins for `dev` environment in
> `webpack.config.js`. Initially it was added only for `production`
> environment. but it is needed for both, because React code is conditional
> based on environment variables set.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2017-07-28 10:32:28 | Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard |
| Previous Message | Dave Page | 2017-07-28 10:30:58 | Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel |