Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hi

PFA patch.

On Tue, Jun 13, 2017 at 9:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hmm, this seems to have broken the feature tests. Can you look at that
> ASAP please? I think it's because the tab text has changed.
>
​Yes, now it will search for 'Query -' ​instead of 'Query-1'.

>
> On Tue, Jun 13, 2017 at 11:34 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> > Thanks, patch applied.
> >
> > On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
> > <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >> Hi
> >>
> >> Changes:
> >>
> >> 1) When Query tool is opened, right now - panel title is displayed as
> "Query
> >> - 1 ", instead it should display Query - [db_name] on [server_name] as
> in
> >> pgAdmin3.
> >>
> >> 2) When Edit grid is opened for table, the panel title should display
> >> Edit Data - [server_name] - [db_name] - [table_name]
> >>
> >> These names are more meaningful instead of "Query - #'. helpful while
> >> switching to panel tabs.
> >>
> >> 3) If panel is inactive and its title is quite long, show ellipsis(...),
> >> otherwise display full title.
> >>
> >> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
> >>
> >> Also tested with preference settings > Open query tool in new tab. It
> >> works!!.
> >>
> >> Please find attached patch
> >>
> >> Thanks
> >> Surinder
> >>
> >>
> >> --
> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> >> To make changes to your subscription:
> >> http://www.postgresql.org/mailpref/pgadmin-hackers
> >>
> >
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>