Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Shirley Wang <swang(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title
Date: 2017-06-13 17:42:03
Message-ID: CAM5-9D_BGfA-wyYjmmcY_bHt7bWHaLpGYwnUT2aBjvwrNn7D+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:

> Awesome!! This is super helpful :)
>
> Does this affect a new query window (currently the title is 'Query -
> untitled')?
>
​Yes, in this case the title of query window will be Query - [db_name] on
[server_name]. It was showing 'Query - untitled' when opened from context
menu because no tree information was passed.

>
> On Mon, Jun 12, 2017 at 10:25 PM Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi
>>
>> Changes:
>>
>> 1) When Query tool is opened, right now - panel title is displayed as
>> "Query - 1 ", instead it should display Query - [db_name] on
>> [server_name] as in pgAdmin3.
>>
>> 2) When Edit grid is opened for table, the panel title should display
>> Edit Data - [server_name] - [db_name] - [table_name]
>>
>> These names are more meaningful instead of "Query - #'. helpful while
>> switching to panel tabs.
>>
>> 3) If panel is inactive and its title is quite long, show ellipsis(...),
>> otherwise display full title.
>>
>> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>>
>> Also tested with preference settings > Open query tool in new tab. It
>> works!!.
>>
>> Please find attached patch
>>
>> Thanks
>> Surinder
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shirley Wang 2017-06-13 17:54:24 Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title
Previous Message Surinder Kumar 2017-06-13 17:37:59 Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title