Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title
Date: 2017-06-13 16:24:40
Message-ID: CA+OCxowwR4nfLN35B6kJVhmsC_atHa6nVe20PiGGS4dYtEp8KA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hmm, this seems to have broken the feature tests. Can you look at that
ASAP please? I think it's because the tab text has changed.

On Tue, Jun 13, 2017 at 11:34 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, patch applied.
>
> On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> Hi
>>
>> Changes:
>>
>> 1) When Query tool is opened, right now - panel title is displayed as "Query
>> - 1 ", instead it should display Query - [db_name] on [server_name] as in
>> pgAdmin3.
>>
>> 2) When Edit grid is opened for table, the panel title should display
>> Edit Data - [server_name] - [db_name] - [table_name]
>>
>> These names are more meaningful instead of "Query - #'. helpful while
>> switching to panel tabs.
>>
>> 3) If panel is inactive and its title is quite long, show ellipsis(...),
>> otherwise display full title.
>>
>> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>>
>> Also tested with preference settings > Open query tool in new tab. It
>> works!!.
>>
>> Please find attached patch
>>
>> Thanks
>> Surinder
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shirley Wang 2017-06-13 16:38:08 Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title
Previous Message Joao Pedro De Almeida Pereira 2017-06-13 15:51:26 Re: [patch] Correct bundle test that polluted Python modules