From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Be clear about what log_checkpoints emits in the documentation |
Date: | 2021-12-24 12:31:57 |
Message-ID: | CALj2ACXWTSbdnJTkFMCx2C3_gO_C6DmxCRHLmAa-uX3qVUiz5g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 24, 2021 at 11:30 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Thu, 23 Dec 2021 20:56:22 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> > Hi,
> >
> > Currently the documentation of the log_checkpoints GUC says the following:
> >
> > Some statistics are included in the log messages, including the number
> > of buffers written and the time spent writing them.
> >
> > Usage of the word "Some" makes it a vague statement. Why can't we just
> > be clear about what statistics the log_checkpoints GUC can emit, like
> > the attached patch?
> >
> > Thoughts?
>
> It seems like simply a maintenance burden of documentation since it
> doesn't add any further detail of any item in a checkpoint log
> message. But I'm not sure we want detailed explanations for them and
> it seems to me we deliberately never explained the detail of any log
> messages.
Agreed. "Some statistics" can cover whatever existing and newly added
stuff, if any. Let it be that way.
Regards,
Bharath Rupireddy.
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-12-24 12:33:54 | Re: correct the sizes of values and nulls arrays in pg_control_checkpoint |
Previous Message | Bharath Rupireddy | 2021-12-24 12:24:02 | Re: Add checkpoint and redo LSN to LogCheckpointEnd log message |