| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: correct the sizes of values and nulls arrays in pg_control_checkpoint |
| Date: | 2021-12-24 12:33:54 |
| Message-ID: | CALj2ACUjFq6MWcbjOi01zAgeKcpO0DTDO8wf6qOprJHmx9ukDA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 23, 2021 at 9:16 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Thu, Dec 23, 2021 at 9:13 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
> >
> > On Thu, Dec 23, 2021, at 8:39 AM, Bharath Rupireddy wrote:
> >
> > pg_control_checkpoint emits 18 columns whereas the values and nulls
> > arrays are defined to be of size 19. Although it's not critical,
> > attaching a tiny patch to fix this.
> >
> > Good catch! I'm wondering if a constant wouldn't be useful for such case.
>
> Thanks. I thought of having a macro, but it creates a lot of diff with
> the previous versions as we have to change for other pg_control_XXX
> functions.
I've added a CF entry to not lose track -
https://commitfest.postgresql.org/36/3475/
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2021-12-24 13:12:00 | Re: Add new function to convert 32-bit XID to 64-bit |
| Previous Message | Bharath Rupireddy | 2021-12-24 12:31:57 | Re: Be clear about what log_checkpoints emits in the documentation |