Re: Be clear about what log_checkpoints emits in the documentation

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: bharath(dot)rupireddyforpostgres(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Be clear about what log_checkpoints emits in the documentation
Date: 2021-12-24 06:00:44
Message-ID: 20211224.150044.682333537293997681.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 23 Dec 2021 20:56:22 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> Hi,
>
> Currently the documentation of the log_checkpoints GUC says the following:
>
> Some statistics are included in the log messages, including the number
> of buffers written and the time spent writing them.
>
> Usage of the word "Some" makes it a vague statement. Why can't we just
> be clear about what statistics the log_checkpoints GUC can emit, like
> the attached patch?
>
> Thoughts?

It seems like simply a maintenance burden of documentation since it
doesn't add any further detail of any item in a checkpoint log
message. But I'm not sure we want detailed explanations for them and
it seems to me we deliberately never explained the detail of any log
messages.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-12-24 06:32:10 Re: An obsolete comment of pg_stat_statements
Previous Message Kyotaro Horiguchi 2021-12-24 05:51:34 Re: Add checkpoint and redo LSN to LogCheckpointEnd log message