Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: 2025-03-17 06:55:16
Message-ID: CALDaNm3V5DQSbZGxhYH+3MMMm-YdgOg+RdJ-ni6D0TZx_=Xd7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 3 Feb 2025 at 21:08, Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> wrote:
>
> Hi, Alexander!
> Thanks for your advices and recommendations!
>
> >I don't think we need a separate 0003 patch with refactoring. It's
> >probably good idea to keep this functionality as a separate patch, but
> >let's make then it a 0001, which prepares functions used by 0002 and
> >0003.
>
> Done. 0003 was created separately to better understand what changes were
> made after the verified changes 0001 and 0002.
>
> >Please, check my thoughts on how this patch could be further
> >developed. Given amount of work to be done, I doubt that'a a subject
> >for pg18. But I think you could continue this work, and we could
> >consider it for early pg19 cycle.
>
> Good. I'll try to collect and summarize the opinions of colleagues on
> these issues [1], and then put them up for discussion in this thread.

I noticed that Alvaro's comments from [1] have not yet been addressed,
I have changed the status of commitfest entry to "Waiting on Author",
please address them and update it to "Needs review".
[1] - https://www.postgresql.org/message-id/202502031640.zem6orjmmxoz@alvherre.pgsql

Regards,
Vignesh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-03-17 06:58:32 Re: Fwd: lwlocknames.h beautification attempt
Previous Message David G. Johnston 2025-03-17 06:52:31 Re: Forbid to DROP temp tables of other sessions