| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fwd: lwlocknames.h beautification attempt |
| Date: | 2025-03-17 06:58:32 |
| Message-ID: | 3932700.1742194712@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Gurjeet Singh <gurjeet(at)singh(dot)im> writes:
> On Sun, Mar 16, 2025 at 7:53 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I'm confused. Tom and I both said we didn't like this change,
> To me, Tom's feedback felt as being between ambivalent to the change and perhaps
> agree with the change, as long as pgindent did not throw a fit, which
> it did not.
Geez, are we really going to argue about whitespace in a generated
file? But anyway, what I said was that I didn't like the style with
the define'd symbol right-justified, because it didn't look like
anything else in our code. I'm entirely okay with the committed
version, which has plenty of precedent formatting-wise.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-03-17 07:03:13 | Re: 64 bit numbers vs format strings |
| Previous Message | vignesh C | 2025-03-17 06:55:16 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |