Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

From: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: 2025-03-17 13:36:56
Message-ID: 46e602cb-0aaa-4659-aa02-8d22cae770b5@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I noticed that Alvaro's comments from [1] have not yet been addressed,

Thanks!
I'm sorry, I missed this comment.

> I'm wary of taking some static functions and making them non-static
...
> For example, perhaps you don't need to expose both StoreRelCheck and
> SetRelationNumChecks, but instead would be better served by exposing
> StoreConstraints? ... Or maybe use AddRelationNewConstraints() ...

I replaced explosion of functions StoreRelCheck + SetRelationNumChecks
to StoreConstraints explosion. Probably function
AddRelationNewConstraints is not very suitable for this ...

[1]
https://www.postgresql.org/message-id/202502031640.zem6orjmmxoz@alvherre.pgsql

--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com

Attachment Content-Type Size
v37-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch text/plain 146.0 KB
v37-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch text/plain 211.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matheus Alcantara 2025-03-17 13:46:32 Re: read stream on amcheck
Previous Message Steven Niu 2025-03-17 13:28:50 Re: Forbid to DROP temp tables of other sessions