| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Documentation update of wal_retrieve_retry_interval to mention table sync worker |
| Date: | 2025-01-13 07:03:38 |
| Message-ID: | CALDaNm1_v-+Y3rPYS_c9DRNJGui66LHuc1vAq1d95=y8EiqDkg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 6 Jan 2025 at 08:47, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh,
>
> Some review comments for your v2 patch.
>
> ======
> doc/src/sgml/logical-replication.sgml
>
> AFAICT the only difference you made is changing:
> FROM "a special kind of apply process"
> TO "a special kind of table synchronization worker process".
>
> There is only ONE kind of tablesync process, so I think saying "a
> special kind of table synchronization worker process" seems
> misleading. I also thought maybe it is better to mention that this is
> PER table.
>
> SUGGESTION:
> ... a special table synchronization worker process per table.
Thanks, the updated v3 version patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Improve-documentation-on-table-synchronization-wo.patch | text/x-patch | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-01-13 07:18:28 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Peter Smith | 2025-01-13 06:52:15 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |