| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Date: | 2025-01-13 07:18:28 |
| Message-ID: | CAHut+Pvj4t7mQ9hM32PYbRFKPnKzGir6hQ3Zw3_7xQ-BL5=vxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 13, 2025 at 5:52 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 2 Jan 2025 at 15:57, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > On Thu, Jan 2, 2025 at 8:16 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > Hi Nisha,
> > >
> > > Here are some minor review comments for patch v58-0002.
> > >
...
>
> 2) We can mention this as 1d instead of 24h as we want to represent 1
> day similar to how we have mentioned for log_rotation_age:
> index a2ac7575ca..7284edfbc1 100644
> --- a/src/backend/utils/misc/postgresql.conf.sample
> +++ b/src/backend/utils/misc/postgresql.conf.sample
> @@ -337,6 +337,7 @@
> #wal_sender_timeout = 60s # in milliseconds; 0 disables
> #track_commit_timestamp = off # collect timestamp of transaction commit
> # (change requires restart)
> +#idle_replication_slot_timeout = 24h # in minutes; 0 disables
>
Hi Vignesh. AFAIK that is due to a previous review comment of mine
where I suggested we should use 24h format here, because this GUC
default is described as "24 hours" in the config.sgml, and I felt the
sample should match its own documentation.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-01-13 07:29:05 | Re: Documentation update of wal_retrieve_retry_interval to mention table sync worker |
| Previous Message | vignesh C | 2025-01-13 07:03:38 | Re: Documentation update of wal_retrieve_retry_interval to mention table sync worker |