From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
---|---|
To: | vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Documentation update of wal_retrieve_retry_interval to mention table sync worker |
Date: | 2025-01-13 09:13:34 |
Message-ID: | CANhcyEXvkLf76k4vJVEH68-aWM5yz2AHLtpQwp39ZP2uZtS5Zg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 13 Jan 2025 at 12:33, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, 6 Jan 2025 at 08:47, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi Vignesh,
> >
> > Some review comments for your v2 patch.
> >
> > ======
> > doc/src/sgml/logical-replication.sgml
> >
> > AFAICT the only difference you made is changing:
> > FROM "a special kind of apply process"
> > TO "a special kind of table synchronization worker process".
> >
> > There is only ONE kind of tablesync process, so I think saying "a
> > special kind of table synchronization worker process" seems
> > misleading. I also thought maybe it is better to mention that this is
> > PER table.
> >
> > SUGGESTION:
> > ... a special table synchronization worker process per table.
>
> Thanks, the updated v3 version patch has the changes for the same.
>
Hi Vignesh,
I reviewed the v3 patch. And it looks good to me.
Thanks and Regards,
Shlok Kyal
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2025-01-13 09:22:31 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
Previous Message | Amit Kapila | 2025-01-13 08:55:26 | Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING |