| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-08-08 15:52:15 |
| Message-ID: | CALDaNm1QQK_Pgx35LrJGuRxBzzYSO8rm1YGJF4w8hYc3Gm+5NQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 8 Aug 2024 at 08:30, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh, Here are my v20240807-0003 review comments.
>
> 2a.
> The paragraph starts by saying "Sequence data is not replicated.". It
> seems wrong now. Doesn't that need rewording or removing?
Changed it to incremental sequence changes.
> ~
>
> 2b.
> Should the info "If, however, some kind of switchover or failover..."
> be mentioned in the "Logical Replication Failover" section [2],
> instead of here?
I think mentioning this here is appropriate. The other section focuses
more on how logical replication can proceed with a new primary. Once
the logical replication setup is complete, sequences can be refreshed
at any time.
Rest of the comments are fixed, the attached v20240808 version patch
has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v20240808-0001-Introduce-pg_sequence_state-function-for-e.patch | text/x-patch | 11.4 KB |
| v20240808-0003-Enhance-sequence-synchronization-during-su.patch | text/x-patch | 90.6 KB |
| v20240808-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch | text/x-patch | 90.2 KB |
| v20240808-0004-Documentation-for-sequence-synchronization.patch | text/x-patch | 23.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-08-08 15:55:03 | Re: Logical Replication of sequences |
| Previous Message | Tom Lane | 2024-08-08 14:49:42 | Re: [PATCH] Add crc32(text) & crc32(bytea) |