| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add crc32(text) & crc32(bytea) |
| Date: | 2024-08-08 14:49:42 |
| Message-ID: | 2224670.1723128582@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Thu, Aug 08, 2024 at 04:27:20PM +0200, Peter Eisentraut wrote:
>> The correct return type of a CRC operation in general is some kind of exact
>> numerical type. Just pick the best one that fits the result. I don't think
>> bytea is appropriate.
> That would leave us either "integer" or "bigint". "integer" is more
> correct from a size perspective, but will result in negative values because
> it is signed. "bigint" uses twice as many bytes but won't display any CRC
> values as negative.
bigint seems fine to me; we have used that in other places as a
substitute for uint32, eg block numbers in contrib/pageinspect.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-08-08 15:52:15 | Re: Logical Replication of sequences |
| Previous Message | Nathan Bossart | 2024-08-08 14:35:33 | Re: [PATCH] Add crc32(text) & crc32(bytea) |