| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-08-09 07:10:08 |
| Message-ID: | CAHut+Puy3CDGKeoShGV3mcpw8H8tWBA20NtbQBsUMER-fAPTaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Vignesh, here are my review comments for the sequences docs patch
v20240808-0004.
======
doc/src/sgml/logical-replication.sgml
The new section content looked good.
Just some nitpicks including:
- renamed the section "Replicating Sequences"
- added missing mention about how to publish sequences
- rearranged the subscription commands into a more readable list
- some sect2 titles were very long; I shortened them.
- added <warning> markup for the sequence definition advice
- other minor rewording and typo fixes
~
1.
IMO the "Caveats" section can be removed.
- the advice to avoid changing the sequence definition is already
given earlier in the "Sequence Definition Mismatches" section
- the limitation of "incremental synchronization" is already stated in
the logical replication "Limitations" section
- (FYI, I removed it already in my nitpicks attachment)
======
doc/src/sgml/ref/alter_subscription.sgml
nitpick - I reversed the paragraphs to keep the references in a natural order.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
On Fri, Aug 9, 2024 at 1:52 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 8 Aug 2024 at 08:30, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi Vignesh, Here are my v20240807-0003 review comments.
> >
> > 2a.
> > The paragraph starts by saying "Sequence data is not replicated.". It
> > seems wrong now. Doesn't that need rewording or removing?
>
> Changed it to incremental sequence changes.
>
> > ~
> >
> > 2b.
> > Should the info "If, however, some kind of switchover or failover..."
> > be mentioned in the "Logical Replication Failover" section [2],
> > instead of here?
>
> I think mentioning this here is appropriate. The other section focuses
> more on how logical replication can proceed with a new primary. Once
> the logical replication setup is complete, sequences can be refreshed
> at any time.
>
> Rest of the comments are fixed, the attached v20240808 version patch
> has the changes for the same.
>
> Regards,
> Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| PS_NITPICKS_202400809_seq_0004.txt | text/plain | 11.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Koval | 2024-08-09 07:18:29 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-08-09 06:59:29 | RE: Conflict detection and logging in logical replication |