| From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][SonarQube] Critical issue fixes - servers |
| Date: | 2020-07-09 13:44:30 |
| Message-ID: | CAKtn9dP8cv6ss5zjjsHTWkVkmeWDbWsK3PFNRW9BEH7TZW_ijA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
Please find the updated patch below which fixes the issue in sslcompression
changes.
On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
wrote:
> Hi Hackers,
>
> Please find the attached patch which includes sonarqube fixes :
>
> 1. Refactor this function to reduce its Cognitive Complexity from 18 to
> the 15 allowed
> for *check_ssl_fields* in servers/__init__.py
> 2. Refactor this function to reduce its Cognitive Complexity from 25 to
> the 15 allowed
> for *update *in servers/__init__.py
>
> *Note: Changes were tested in both Server mode & Desktop mode
> respectively.*
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
| Attachment | Content-Type | Size |
|---|---|---|
| server-cognitive-comp-part-01_v2.patch | application/octet-stream | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Mohite | 2020-07-09 13:48:25 | [pgAdmin][RM5329][Code Coverage] Improve API test cases for FTS Configuration, FTS Dictionary, FTS Parser, FTS Template |
| Previous Message | Akshay Joshi | 2020-07-09 13:30:14 | Re: [pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed) |