| From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin][SonarQube] Critical issue fixes - servers |
| Date: | 2020-07-09 11:16:50 |
| Message-ID: | CAKtn9dNeoskXBtK3q3bQvM__GgLrcBJnADSaWi_fEr_+WTOCYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
Please find the attached patch which includes sonarqube fixes :
1. Refactor this function to reduce its Cognitive Complexity from 18 to the
15 allowed
for *check_ssl_fields* in servers/__init__.py
2. Refactor this function to reduce its Cognitive Complexity from 25 to the
15 allowed
for *update *in servers/__init__.py
*Note: Changes were tested in both Server mode & Desktop mode respectively.*
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
| Attachment | Content-Type | Size |
|---|---|---|
| server-cognitive-comp-part-01.patch | application/octet-stream | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yogesh Mahajan | 2020-07-09 12:36:43 | [pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed) |
| Previous Message | Yogesh Mahajan | 2020-07-09 11:06:57 | Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code |