Re: [pgAdmin][SonarQube] Critical issue fixes - servers

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][SonarQube] Critical issue fixes - servers
Date: 2020-07-10 06:21:17
Message-ID: CANxoLDdx9HcK1fjzKNja+y4e9O9qwJ74wou05UKyr4KDwJC2Dw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Jul 9, 2020 at 7:15 PM Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> Please find the updated patch below which fixes the issue in
> sslcompression changes.
>
> On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which includes sonarqube fixes :
>>
>> 1. Refactor this function to reduce its Cognitive Complexity from 18 to
>> the 15 allowed
>> for *check_ssl_fields* in servers/__init__.py
>> 2. Refactor this function to reduce its Cognitive Complexity from 25 to
>> the 15 allowed
>> for *update *in servers/__init__.py
>>
>> *Note: Changes were tested in both Server mode & Desktop mode
>> respectively.*
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-10 06:21:40 Re: [pgAdmin4][Patch] - SonarQube Fixes
Previous Message Akshay Joshi 2020-07-10 06:21:05 Re: [pgAdmin] Regarding Alert-box on login page