Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results

Hi Aditya/Akshay,

On Wed, Dec 9, 2020 at 2:59 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hello Rahul,
>
> Found below issues:
> 1) The data grid is not fetching more than 1000 records now, gives a
> console error:
> sqleditor.js:1264 Uncaught TypeError: self.enable_disable_download_btn is
> not a function
> at child.fetch_next (sqleditor.js:1264)
>
*Fixed*

>
> 2) The sqleditor test cases are failing.
>
*This has been taken care of, and added more test cases. *

> 3) Fix pep8 issues.
> 4) Fix linter issues.
>
*Sorry for these issues, last minute code changes* 😣

> 5) Please check the doc changes again, it's not clear to me.
>
*This has been corrected now.*

>
> I didn't check but make sure the GUI tests for the sqleditor runs fine
> since the behaviour has changed now.
>
*These are fixed now.*

>
> On Wed, Dec 9, 2020 at 1:53 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Aditya
>>
>> Can you please review this patch?
>>
>> On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the updated patch below.
>>>
>>> On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat <
>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch which resolves the issue of macros query
>>>> results download, have used async cursor to achieve this functionality,
>>>> where for downloading the results, cursor is scrolled back to 0 and end of
>>>> the records, and reset again while user scrolling on Data Output table.
>>>>
>>>> QA/Reviewer needs to observe below issues if it occurs:
>>>>
>>>> 1. If records are more like 5000 or 10000, try to fetch records by
>>>> scrolling at least (2000), now save the results by clicking the download
>>>> button, it should save the file, and now try scrolling again, the data
>>>> should be shown continuously and not any abrupt end or unexpected records
>>>> order.
>>>> 2. Also, the download button is now "Save results to CSV/TXT" where
>>>> it will only get enabled when there are valid records in the Data Output.
>>>>
>>>>
>>>> Also a minor fix of the add folder icon issue is also added into this
>>>> patch.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.