From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | PATCH: Dialogue control buttons should be consistent (pgAdmin4) |
Date: | 2017-01-06 13:42:13 |
Message-ID: | CAKKotZTSSsps_Zb033pSHg+v_3rvtUunoAZtCWVDnze+uiUv0w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
PFA patch to fix the issue where some dialogue control buttons were not
consistent with others dialogs.
RM#1364
Patch fixes,
1) Preferences: Close, Maximise, Pin
- Removed Pin button
2) Wizards: Close
- Added Maximise button, which is can used with 'show_header_maximize_btn'
option.
3) Properties: Close
- N/A, As this is custom wcDocker panel not alertify dialog.
4) User manager: Maximise
- We can't have close button in User Manager as data validation was main
requirement, If user clicks on right top close button while having dirty
data in dialog then we can't stop alertify dialog from closing even with
confirm prompt hence we have removed the button.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
RM_1364.patch | application/octet-stream | 6.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-01-06 14:09:40 | pgAdmin 4 commit: Format JSON more efficiently. This can significantly |
Previous Message | Neel Patel | 2017-01-06 11:53:06 | Re: [pgAdmin4]: RM-1910 - Remember last used directory in the file manager |