| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Dialogue control buttons should be consistent (pgAdmin4) |
| Date: | 2017-01-08 10:35:49 |
| Message-ID: | CA+OCxow9p_12KSQXX8nPpPC=QjLkYfx0+y47=CRKqc0Zq+482Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Friday, January 6, 2017, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where some dialogue control buttons were not
> consistent with others dialogs.
> RM#1364
>
> Patch fixes,
> 1) Preferences: Close, Maximise, Pin
> - Removed Pin button
>
> 2) Wizards: Close
> - Added Maximise button, which is can used with 'show_header_maximize_btn'
> option.
>
> 3) Properties: Close
> - N/A, As this is custom wcDocker panel not alertify dialog.
>
> 4) User manager: Maximise
> - We can't have close button in User Manager as data validation was main
> requirement, If user clicks on right top close button while having dirty
> data in dialog then we can't stop alertify dialog from closing even with
> confirm prompt hence we have removed the button.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-01-08 10:37:03 | Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature] |
| Previous Message | Dave Page | 2017-01-08 09:58:06 | pgAdmin 4 commit: Allow setting of effective_io_concurrency on tablespa |