From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4]: RM-1910 - Remember last used directory in the file manager |
Date: | 2017-01-06 11:53:06 |
Message-ID: | CACCA4P1ZBQ-VooBZw0+QpPu2hbqpjDx+=Zuv7+sFaJfFCzAXww@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
I am able to reproduce the issue with the steps mentioned.
Please find attached patch file for the fix.
I have tested on web and desktop mode. Do review it and let us know for
comments.
Thanks,
Neel Patel
On Tue, Jan 3, 2017 at 3:18 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Fri, Dec 23, 2016 at 6:17 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
> > Hi Dave,
> >
> > I have tried to reproduce the issue with both python 2 & python3 but no
> luck
> > and from the logs, it looks like issue with global name 'transid' not
> > defined so i don't think we have changed anything in that logic but yes
> we
> > need to fix this.
> >
> > Can you please let me know the steps to reproduce so that i can fix this
> > issue ?
>
> 1) Apply patch and run pgAdmin
>
> 2) Open pgAdmin (I'm doing so in Chrome)
>
> 3) Browse to a database, and open the query tool
>
> 4) Hit the File Open button.
>
> Note: I just found I couldn't reproduce this with SERVER_MODE = True,
> only with SERVER_MODE = False.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
RM_1910_v3.patch | application/octet-stream | 7.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-01-06 13:42:13 | PATCH: Dialogue control buttons should be consistent (pgAdmin4) |
Previous Message | Khushboo Vashi | 2017-01-06 10:55:20 | [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement |