From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix minor patches (pgAdmin4) |
Date: | 2016-06-02 12:41:23 |
Message-ID: | CAKKotZTQx-Lzuffs97-fpf9LcUqcwH7ERrUA0-041FXQRMRdzA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
PFA updated patch for RM#1234.
Regards,
Murtuza
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Jun 2, 2016 at 3:38 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:
>
> On Wed, Jun 1, 2016 at 1:23 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA minor patches to fix RM#1234, RM#1279.
>>
> I've committed the fix for RM#1276.
>
> But - Proposed fix for RM#1234 does not look right to me.
>
> Consider a name, value has ';' (semicolon) within it, the SQL will
> generated will be wrong.
> i.e. Put a semicolon in comments.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
Attachment | Content-Type | Size |
---|---|---|
RM_1234.patch | application/octet-stream | 760 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-02 12:53:33 | Re: PATCH: To fix expanding server if server inaccessible (pgAdmin4) |
Previous Message | Murtuza Zabuawala | 2016-06-02 12:05:50 | PATCH: Fixed issue in Index node (pgAdmin4) |