From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix minor patches (pgAdmin4) |
Date: | 2016-06-03 10:05:04 |
Message-ID: | CAG7mmox7zjkESFbrrd+joDfGEN+TTHKmEEQryp5FeCdLOOZ8oQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Thu, Jun 2, 2016 at 6:11 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA updated patch for RM#1234.
>
Please do not tweak the '\n' off the output, but - fix the issue from the
template itself.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
>
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 2, 2016 at 3:38 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>> On Wed, Jun 1, 2016 at 1:23 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patches to fix RM#1234, RM#1279.
>>>
>> I've committed the fix for RM#1276.
>>
>> But - Proposed fix for RM#1234 does not look right to me.
>>
>> Consider a name, value has ';' (semicolon) within it, the SQL will
>> generated will be wrong.
>> i.e. Put a semicolon in comments.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2016-06-03 10:07:02 | pgAdmin 4 commit: Fixes #1285 - Update the comments (description) over |
Previous Message | Murtuza Zabuawala | 2016-06-03 10:04:56 | PATCH: To fix issue in table node (pgAdmin4) |