From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix minor patches (pgAdmin4) |
Date: | 2016-06-02 10:08:28 |
Message-ID: | CAG7mmoxXRbZer1d2RZKLcu3u2o7Nhmg8GHNtsrF6pUOsbyQsvA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, Jun 1, 2016 at 1:23 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA minor patches to fix RM#1234, RM#1279.
>
I've committed the fix for RM#1276.
But - Proposed fix for RM#1234 does not look right to me.
Consider a name, value has ';' (semicolon) within it, the SQL will
generated will be wrong.
i.e. Put a semicolon in comments.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2016-06-02 10:10:57 | Re: PATCH: To fix the issue in type node (pgAdmin4) |
Previous Message | Ashesh Vashi | 2016-06-02 10:05:58 | pgAdmin 4 commit: Fixes #1276 - Resolved an issue - 'TypeError: c is un |