Re: PATCH: To fix the issue in Database node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: George Gelashvili <ggelashvili(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue in Database node (pgAdmin4)
Date: 2017-02-01 10:08:17
Message-ID: CAKKotZTG2xLJ8e8StAgMZ13fKiDxnnLfQwc+mjSfq2vAst9eLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

PFA updated patch, issue was conn.release(did=did) was removing all
connection for same database from connection manager.
We have now created new connection for offline updates using "conn_id"
parameter instead of did.

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jan 30, 2017 at 8:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Mon, Jan 30, 2017 at 5:31 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > Please find updated patch, Tested against maintenance database as well.
>
> I can change parameters on the maintenance DB now, but it still
> crashes if I try to change the comment. Both operations on other
> databases seem to work OK.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_2024_v5.patch application/octet-stream 11.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-02-01 10:23:49 pgAdmin 4 commit: Properly handle setting comments and other options on
Previous Message Fahar Abbas 2017-02-01 10:06:19 Re: [Patch] Show databases for Greenplum