Re: [Patch] Show databases for Greenplum

From: Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: George Gelashvili <ggelashvili(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] Show databases for Greenplum
Date: 2017-02-01 10:06:19
Message-ID: CAJFwRrM_XeRYp_QNzJNExW33_bdprHuptNVqne-Dcwk6eArB3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

I was also thinking with same pattern and we need to verify this change
thoroughly.

Thanks Dave.

Regards,

On Wed, Feb 1, 2017 at 2:59 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks George, patch applied.
>
> Fahar; whilst this is a technically simple patch, it was also very
> large. Please keep an eye out for any issues.
>
> On Tue, Jan 31, 2017 at 10:08 PM, George Gelashvili
> <ggelashvili(at)pivotal(dot)io> wrote:
> > Hi Hackers,
> >
> > We're working on https://redmine.postgresql.org/issues/2132
> > This patch allows pgAdmin to list databases and schemas when connected
> to a
> > Greenplum server.
> >
> > The fix was largely allowing pgadmin to load templates that work with
> > Greenplum. To achieve this, we used the versioned template loader in more
> > places where "9.1_plus" was previously hardcoded.
> > We also created a set of "default" template directories so that Greenplum
> > will load the templates that were tagged as 9.1 for now.
> >
> > Tira & George
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-02-01 10:08:17 Re: PATCH: To fix the issue in Database node (pgAdmin4)
Previous Message Dave Page 2017-02-01 09:59:41 Re: [Patch] Show databases for Greenplum