From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | George Gelashvili <ggelashvili(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix the issue in Database node (pgAdmin4) |
Date: | 2017-02-01 10:25:01 |
Message-ID: | CA+OCxoygAmscg2LBBbrzCRq98+Az+M1XcKA0-DWdiaONJL-hOQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - patch applied!
On Wed, Feb 1, 2017 at 10:08 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> PFA updated patch, issue was conn.release(did=did) was removing all
> connection for same database from connection manager.
> We have now created new connection for offline updates using "conn_id"
> parameter instead of did.
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Jan 30, 2017 at 8:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Mon, Jan 30, 2017 at 5:31 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi Dave,
>> >
>> > Please find updated patch, Tested against maintenance database as well.
>>
>> I can change parameters on the maintenance DB now, but it still
>> crashes if I try to change the comment. Both operations on other
>> databases seem to work OK.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-02-01 12:18:55 | [pgAdmin4][Patch] Displaying Zero in Slickgrid editor |
Previous Message | Dave Page | 2017-02-01 10:23:49 | pgAdmin 4 commit: Properly handle setting comments and other options on |