Re: [pgAdmin4][Patch] To fix the issue in Debugger module

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] To fix the issue in Debugger module
Date: 2017-06-23 08:56:45
Message-ID: CAKKotZSTetfb2EEgEkRBcKrREUQnnSt-Uqt5PZSTpdk9ZNMp0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Yes Dave,

You are right, I tested and found that indirect debugging is not working.
But otherwise for direct debugging it works properly.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jun 23, 2017 at 1:20 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA patch to fix the issue in Debugger module where it was unable to
> start
> > debugging if 'plugin_debugger' can not found in shared_preload_libraries.
> > RM#2162
> >
> > Original patch by: Kit Yam Tse
> > (who reported the issue)
> >
> > I just re-based it against current code.
>
> Isn't that code required? We do need plugin_debugger to be present for
> global (indirect) debugging to work. I suppose it may not be required
> for direct debugging, but I haven't tested that.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-23 08:58:50 pgAdmin 4 commit: Add access keys for top level menus.
Previous Message Dave Page 2017-06-23 08:43:04 Re: [pgAdmin4][Patch] To fix the issue in Column module