From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] To fix the issue in Debugger module |
Date: | 2017-06-23 09:02:48 |
Message-ID: | CA+OCxoxRvHnEqMZUC7eM4UsRnAG6a0BM_ys+MteU1Qb8-3y1_w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Yes Dave,
>
> You are right, I tested and found that indirect debugging is not working.
> But otherwise for direct debugging it works properly.
Does the patch take that into account, or are you modifying it?
> On Fri, Jun 23, 2017 at 1:20 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue in Debugger module where it was unable to
>> > start
>> > debugging if 'plugin_debugger' can not found in
>> > shared_preload_libraries.
>> > RM#2162
>> >
>> > Original patch by: Kit Yam Tse
>> > (who reported the issue)
>> >
>> > I just re-based it against current code.
>>
>> Isn't that code required? We do need plugin_debugger to be present for
>> global (indirect) debugging to work. I suppose it may not be required
>> for direct debugging, but I haven't tested that.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-06-23 09:08:00 | Re: [pgAdmin4][Patch] To fix the issue in Debugger module |
Previous Message | Dave Page | 2017-06-23 08:58:50 | pgAdmin 4 commit: Add access keys for top level menus. |