Re: [pgAdmin4][Patch] To fix the issue in Debugger module

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] To fix the issue in Debugger module
Date: 2017-06-23 07:50:20
Message-ID: CA+OCxowifAHZ8kuL2P9gvgS-X6OSzLugbUeUD54ejuiHA5XKrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue in Debugger module where it was unable to start
> debugging if 'plugin_debugger' can not found in shared_preload_libraries.
> RM#2162
>
> Original patch by: Kit Yam Tse
> (who reported the issue)
>
> I just re-based it against current code.

Isn't that code required? We do need plugin_debugger to be present for
global (indirect) debugging to work. I suppose it may not be required
for direct debugging, but I haven't tested that.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-23 08:23:33 pgAdmin 4 commit: Ensure the relevant Makefile targets install node mod
Previous Message Murtuza Zabuawala 2017-06-23 06:37:51 Re: [pgadmin-hackers][patch] History Detail Pane