| From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
|---|---|
| To: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor |
| Date: | 2018-02-27 15:00:30 |
| Message-ID: | CAKKotZSHX0ytBFQE2nu9DR_SpV0h_UK1Hirnph7eHCXD93cZCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thank you for testing it Joao.
--
Regards,
Murtuza
On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hello Murtuza,
>
> The patch looks good, and solves the problem. Run the patch on our CI and
> everything is green.
>
> Thanks
> Joao
>
> On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue where Tab key was not working as expected in
>> query tool editor.
>>
>> Steps to reproduce:
>> 1) Type any multiline sql/text.
>> 2) select the complete sql by pressing Ctrl+A.
>> 3) Press Tab key multiple times, you will see the problem in code
>> indentation.
>>
>> Please review.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2018-02-27 15:02:46 | [pgAdmin4][RM#3156] Fix PEP-8 issues |
| Previous Message | Joao De Almeida Pereira | 2018-02-27 14:59:07 | Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor |