| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor |
| Date: | 2018-02-27 15:20:57 |
| Message-ID: | CA+OCxoxaUoaLKUeLcD+4FSKtYeYNqpETE3qMES_tYdQYQx6fsA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Tue, Feb 27, 2018 at 3:00 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Thank you for testing it Joao.
>
> --
> Regards,
> Murtuza
>
> On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hello Murtuza,
>>
>> The patch looks good, and solves the problem. Run the patch on our CI and
>> everything is green.
>>
>> Thanks
>> Joao
>>
>> On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where Tab key was not working as expected in
>>> query tool editor.
>>>
>>> Steps to reproduce:
>>> 1) Type any multiline sql/text.
>>> 2) select the complete sql by pressing Ctrl+A.
>>> 3) Press Tab key multiple times, you will see the problem in code
>>> indentation.
>>>
>>> Please review.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-02-27 15:24:31 | Re: RM3079 fix for wrong sql datetime/time related datatypes |
| Previous Message | Dave Page | 2018-02-27 15:20:33 | pgAdmin 4 commit: Fix block indent/outdent with configurable width. Fix |