Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor

From: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor
Date: 2018-02-27 14:59:07
Message-ID: CAE+jjano6661i5zF70G8goYySOQya9zE+GNX1iBHN3qz8wLnNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Murtuza,

The patch looks good, and solves the problem. Run the patch on our CI and
everything is green.

Thanks
Joao

On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch to fix the issue where Tab key was not working as expected in
> query tool editor.
>
> Steps to reproduce:
> 1) Type any multiline sql/text.
> 2) select the complete sql by pressing Ctrl+A.
> 3) Press Tab key multiple times, you will see the problem in code
> indentation.
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2018-02-27 15:00:30 Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor
Previous Message Harshal Dhumal 2018-02-27 14:36:56 RM3079 fix for wrong sql datetime/time related datatypes