Re: Added variable macro for generic db objects

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Added variable macro for generic db objects
Date: 2016-02-03 10:07:35
Message-ID: CAKKotZRk_unRbmGPzAbmbsBXDKO9_CUh_emeeaACRPi4y3-+cw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Ashesh,

PFA updated patch for generic variable macro as per Neel's suggestion, now
it will take collection instead of single key/value pair.

For example,

options_collection = [
{*name*: 'Option-1', *value*: 'Value-1'},
{*name*: 'Option-2', *value*: 'Value-2'},
{*name*: 'Option-3', *value*: 'Value-3'},
]

*Way to use in template:*

VARIABLE.SET(conn, object_type, object_name, options_collection)
VARIABLE.UNSET(conn, object_type, object_name, options_collection)

*Result:*
ALTER DB_OBJ TEST
SET (Option-1=Value-1, Option-2=Value-2, Option-3=Value-3);

ALTER DB_OBJ TEST
RESET (Option-1,Option-2,Option-3);

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Feb 2, 2016 at 7:46 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Thanks - checked in!
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Tue, Feb 2, 2016 at 6:31 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA updated patch, I missed adding parentheses in previous patch for
>> UNSET macro .
>>
>> Thanks.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Tue, Feb 2, 2016 at 5:49 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to add another generic macro for variable control, previously
>>> written macro was specific to database node and not usable with other db
>>> objects.
>>>
>>> *How to use:*
>>> VARIABLE.SET(conn, object_type, object_name, variable_name, value)
>>> VARIABLE.UNSET(conn, object_type, object_name, variable_name)
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

Attachment Content-Type Size
added_generic_macro_v3.patch application/octet-stream 1.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-02-03 10:11:52 Re: PATCH: Tablespace Node [pgAdmin4]
Previous Message Dave Page 2016-02-03 10:00:04 Re: pgAdmin 4 commit: Update the runtime to properly support Windows.