Re: pgAdmin 4 commit: Update the runtime to properly support Windows.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Update the runtime to properly support Windows.
Date: 2016-02-03 10:00:04
Message-ID: CA+OCxoyoh_9n9iSG-Vyt_LNqbVYEsN09AfFSJe+YMECz2nDebw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Wed, Feb 3, 2016 at 5:24 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Below two minor changes.
>
> - We have added below statement two times in Qt project files so removed
> the duplicate entry.
> PY2_VERSION = $$find(PY_VERSION, "^2")

Oops - my bad.

> - Added some instructions in README file for the Windows system.

Thanks - I've tweaked the wording a touch.

> Can you please review attached patch file and let us know for any comments.

Reviewed and applied!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-02-03 10:07:35 Re: Added variable macro for generic db objects
Previous Message Dave Page 2016-02-03 09:59:18 pgAdmin 4 commit: Remove a duplicate code line and add Windows environm